DTSRD-5699.LRD Court Venue - Updates to retrieveCourtVenuesBySearchString API for new model#1108
Open
SabinaHMCTS wants to merge 18 commits intomasterfrom
Open
DTSRD-5699.LRD Court Venue - Updates to retrieveCourtVenuesBySearchString API for new model#1108SabinaHMCTS wants to merge 18 commits intomasterfrom
SabinaHMCTS wants to merge 18 commits intomasterfrom
Conversation
…String API for new model
…String API for new model
…String API for new model
…String API for new model
…String API for new model
…ode API for new model
…ring API for new model
…ring API for new model
…ring API for new model
| String serviceCodes, | ||
| CourtVenueRequestParam requestParam) { | ||
| log.info("{} : Obtaining court venue for search String: searchString: {}, courtTypeId: {}, " | ||
| + "isHearingLocation: {}, isCaseManagementLocation: {}, locationType: {}, " |
Contributor
There was a problem hiding this comment.
serviceCodes should be logged after courtTypeId and before isHearingLocation
| + "isHearingLocation: {}, isCaseManagementLocation: {}, locationType: {}, " | ||
| + "isTemporaryLocation: {} ", | ||
| loggingComponentName, searchString, courtTypeId, requestParam.getIsHearingLocation(), | ||
| loggingComponentName, searchString, courtTypeId,serviceCodes, requestParam.getIsHearingLocation(), |
Contributor
There was a problem hiding this comment.
missing blank space before serviceCodes
|
|
||
| public static final String RET_LOC_VEN_NOTES_7_1 = """ | ||
| request param 'epimms_id' can be passed with 'court_type_id' . Court venues associated with the epimmsId and | ||
| request param 'epimms_id' can be passed with 'court_type_id' . Court venues associated with the epimmsId and |
Contributor
There was a problem hiding this comment.
is removal of blank here known to not cause formatting issues?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
https://tools.hmcts.net/jira/browse/DTSRD-5699
Change description
Does this PR introduce a breaking change? (check one with "x")